Fix Oxford comma in join us page description#8661
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: 05/27/2026 EOD |
egcuriel
left a comment
There was a problem hiding this comment.
Hi @joshjyu!
It was good seeing you in the meeting earlier tonight!
Thank you for the added context regarding the Oxford comma consistency. I appreciate that you explained the intent behind the structural changes, as it provides a clear picture of the overall goal. I find understanding the motivation behind these updates incredibly useful.
I also appreciate you highlighting the changes in the text, as they can sometimes be tricky to spot in a large block. I’ve verified the updates across both desktop and mobile viewports.
As a next step, could you please add screenshots of the updated sections to the PR? It helps ensure the changes are documented in the PR record and makes it easier for the rest of the team to visualize the final result.
If you have any questions or need a hand with the markdown for the images, just let me know. I'm happy to help so we can keep moving forward with our skills issue!
thanks for the review. There are already screenshots in my PR at the bottom. Please check those out. |
egcuriel
left a comment
There was a problem hiding this comment.
Hi @joshjyu!
The images currently attached are cropped tightly to the text snippets. The PR template's visual documentation requirement helps show how the changes render within the overall website UI. Could you update these attachments with wider screenshots that show the full page layout?
The screenshots are updated as requested! |
|
Review ETA: 5/30/2026 |
ldaws003
left a comment
There was a problem hiding this comment.
Good work. You forked the repo and made changes to your own branch. The branch name follows the required format, and your pull request message was well made. Approved
Fixes #8512
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)