fix(build): allow force-rebuilding server binary#548
Merged
harrisoncramer merged 1 commit intodevelopfrom Apr 25, 2026
Merged
Conversation
The build function was checking if server.binary was non-nil to determine if the user provided a custom binary path. After the first build, this field is always set, preventing force-rebuilds from working. Now we track user-provided binaries with a separate flag set during config merge. Closes #545 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
Author
|
@jakubbortlik does this solve your problem in #545 |
Collaborator
Hi Harrison, yes, this fixes the problem. Thanks! |
harrisoncramer
added a commit
that referenced
this pull request
Apr 25, 2026
Merge pull request #548 from harrisoncramer/fix/force-rebuild-binary. Fixes binary builds. This is a #PATCH release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build(true)force-rebuild not working after the initial buildserver.binaryfield was being set during the first build, causing subsequent calls to think it was a user-provided path and skip rebuildingbinary_providedflag set during config mergeCloses #545