fix: replace bare assert with graceful handler in _guess_method (#1614)#1837
Open
codegeek03 wants to merge 1 commit intohttpie:masterfrom
Open
fix: replace bare assert with graceful handler in _guess_method (#1614)#1837codegeek03 wants to merge 1 commit intohttpie:masterfrom
codegeek03 wants to merge 1 commit intohttpie:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1614
When a user passes optional flags between the HTTP method and URL (e.g. http POST --auth-type bearer --auth $TOKEN https://example.org), argparse can assign the URL to request_items instead of url. The existing assert not self.args.request_items then throws a raw, unhelpful AssertionError.
This PR replaces the bare assert with explicit handling:
If url is None and request_items is non-empty, promote request_items[0] to url (recovery path).
If both url and request_items are set, emit a proper self.error(...) message with usage guidance.
A regression test is added for the recovery path.