Open
Conversation
yiyixuxu
approved these changes
Mar 31, 2026
Collaborator
yiyixuxu
left a comment
There was a problem hiding this comment.
looks good to me,
but it's currently failing though
dg845
reviewed
Apr 1, 2026
|
|
||
| @property | ||
| def output_shape(self) -> tuple: | ||
| return (16, 8, 8) |
Collaborator
There was a problem hiding this comment.
Can you check the output shape here? It looks like the model output shape is the same as the input shape (4, 8, 8), so setting output_shape to (16, 8, 8) causes training tests such as TestGlmImageTransformerTraining.test_training to fail with a shape error.
dg845
reviewed
Apr 1, 2026
Collaborator
dg845
left a comment
There was a problem hiding this comment.
Thanks for the PR! Left one question about the test output shape.
In addition to the tests which failed in the latest CI run (https://github.com/huggingface/diffusers/actions/runs/23590953774/job/68695918619?pr=13344), I also got the following test failures locally:
TestGlmImageTransformerCompile.test_torch_compile_repeated_blocks: I think this can be fixed by setting_repeated_blocks = ["GlmImageTransformerBlock"]inGlmImageTransformer2DModel.TestGlmImageTransformer.test_model_parallelism: it looks like some submodules inGlmImageCombinedTimestepSizeEmbeddingsmight end up on different devices, causing a device mismatch error. Could you look into it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.