Skip to content

corrects single file path validation logic#13363

Merged
DN6 merged 2 commits intohuggingface:mainfrom
andrew-w-ross:fix-single-file-path-check
Apr 1, 2026
Merged

corrects single file path validation logic#13363
DN6 merged 2 commits intohuggingface:mainfrom
andrew-w-ross:fix-single-file-path-check

Conversation

@andrew-w-ross
Copy link
Copy Markdown
Contributor

@andrew-w-ross andrew-w-ross commented Mar 30, 2026

What does this PR do?

Fix's loading ModularPipelines loading component specs where pretrained_model_name_or_path is a path.

Didn't bother opening an issue considering the tiny size of the fix.

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Copy Markdown
Collaborator

@DN6 DN6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @andrew-w-ross! Small change requested to the test, but good to merge once that's updated 👍🏽

@andrew-w-ross
Copy link
Copy Markdown
Contributor Author

@DN6 Thanks for the review, I accepted your test changes. Is there anything else I need to do on my side to get this merged? I'm just seeing 5 workflows awaiting approval.

@andrew-w-ross andrew-w-ross force-pushed the fix-single-file-path-check branch from a0b8f96 to 7976953 Compare March 30, 2026 23:46
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@andrew-w-ross andrew-w-ross force-pushed the fix-single-file-path-check branch from 7976953 to d7bd343 Compare April 1, 2026 12:27
@DN6 DN6 merged commit b935381 into huggingface:main Apr 1, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants