Skip to content

adding tagging support#4

Open
dissolve wants to merge 12 commits intoindieweb:masterfrom
dissolve:master
Open

adding tagging support#4
dissolve wants to merge 12 commits intoindieweb:masterfrom
dissolve:master

Conversation

@dissolve
Copy link
Copy Markdown
Member

@dissolve dissolve commented Dec 3, 2014

works for my test case
should not interfere with any current usage

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean set the type to "tag", correct?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes "tag". my bad

@aaronpk
Copy link
Copy Markdown
Member

aaronpk commented Sep 16, 2016

Do you have any tests or documentation for this? It would be great if you added something to the readme showing examples of what the changes do, as well as adding tests for the new functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants