docs(gallery): add documentation for new gallery component#4484
docs(gallery): add documentation for new gallery component#4484brandyscarney wants to merge 14 commits intomajor-9.0from
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
I chose to add this under "Grids" because otherwise we would need to redo the component page to either add a new image for a top-level Gallery section or to add something like "Layout" which would reorder a few of them. I can change this if we want to categorize this differently.
| } | ||
|
|
||
| let npmTag = 'latest'; | ||
| let npmTag = '8.8.6-dev.11777569278.1613db2e'; |
There was a problem hiding this comment.
We need to actually merge this with a dev build otherwise the docs build will fail since Gallery only exists on the dev build.
There was a problem hiding this comment.
I don't love this location of images used by the demos but other demos use this as well so I followed the existing structure.
| </ion-header> | ||
| <ion-content class="ion-padding"> | ||
| <ion-gallery> | ||
| <img src="https://ionicframework.com/docs/img/demos/gallery/01.png" alt="Image 1" /> |
There was a problem hiding this comment.
I am following how other demos include images because the only other way to pass them to StackBlitz is using base64 encoding.
1 participant
Adds documentation & playgrounds for the new
ion-gallerycomponent.Preview
Note: when opening the basic usage or masonry images examples in StackBlitz the img URL must be changed from
https://ionicframework.com/tohttps://ionic-docs-git-fw-7287-ionic1.vercel.appto load the images.