Skip to content

fix(generate): use fully-qualified docker.io image in generated Dockerfiles #2847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mikeland73 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

fix(generate): use fully-qualified docker.io image in generated Dockerfiles #2847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/devbox/generate/tmpl/dev.Dockerfile.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{- if .RootUser }}FROM jetpackio/devbox-root-user:latest
{{- else }}FROM jetpackio/devbox:latest
{{- if .RootUser }}FROM docker.io/jetpackio/devbox-root-user:latest
{{- else }}FROM docker.io/jetpackio/devbox:latest
{{- end}}

# Installing your devbox project
Expand Down
2 changes: 1 addition & 1 deletion internal/devbox/generate/tmpl/prod.Dockerfile.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM jetpackio/devbox:latest
FROM docker.io/jetpackio/devbox:latest

WORKDIR /code
USER root:root
Expand Down
Loading