Skip to content

Log Kafka consumer close errors #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kjamrog merged 3 commits into from
Apr 20, 2026
Merged

Log Kafka consumer close errors #426

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f4419bf
Log Kafka consumer.close errors
kjamrog Apr 20, 2026
147316b
linting
kjamrog Apr 20, 2026
378f87c
Including resolveErrorLog in error report context
kjamrog Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/kafka/lib/AbstractKafkaConsumer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { pipeline } from 'node:stream/promises'
import { setTimeout } from 'node:timers/promises'
import {
InternalError,
isError,
resolveGlobalErrorLogObject,
stringValueSerializer,
type TransactionObservabilityManager,
Expand Down Expand Up @@ -239,8 +240,14 @@ export abstract class AbstractKafkaConsumer<

try {
await this.consumer.close()
} catch {
// Ignoring errors at this stage
} catch (err) {
// Reporting error but not throwing further
const resolvedErrorLog = resolveGlobalErrorLogObject(err)
this.logger.warn(resolvedErrorLog, 'Error while closing Kafka consumer')
this.errorReporter.report({
error: isError(err) ? err : new Error('Unknown error while closing Kafka consumer'),
context: resolvedErrorLog,
})
Comment thread
coderabbitai[bot] marked this conversation as resolved.
}
this.consumer = undefined
}
Expand Down
Loading