introduce DisplayName option in renderOptions#4476
Open
dgyorgy-nokia wants to merge 3 commits intokptdev:mainfrom
Open
introduce DisplayName option in renderOptions#4476dgyorgy-nokia wants to merge 3 commits intokptdev:mainfrom
dgyorgy-nokia wants to merge 3 commits intokptdev:mainfrom
Conversation
dgyorgy-nokia
requested review from
efiacor,
kispaljr,
liamfallon and
mozesl-nokia
as code owners
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dosubot
bot
added
size:XS
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Syncs a missing change from the porch fork by extending renderer configuration to support a human-friendly renderer “DisplayName” (primarily for logging in the async render pipeline).
Changes:
- Add
DisplayNametoRenderOptionsfor renderer identification/logging. - Reformat
RenderOptionsfield alignment for readability.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dosubot
bot
added
size:M
dgyorgy-nokia
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Daniel Gyorgy <daniel.gyorgy@nokia.com>
Signed-off-by: Daniel Gyorgy <daniel.gyorgy@nokia.com>
Signed-off-by: Daniel Gyorgy <daniel.gyorgy@nokia.com>
dgyorgy-nokia
force-pushed
the
async-pipeline
branch
from
2349ea3 to
2d5160d
Compare
liamfallon
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sync changes from porch (nokia-fork)
This logging related change is still missing from the kpt, which is modified back in the porch repository. This is used by the async render pipeline implementation.
Mainly is just about having an optional DisplayName field for the Renderer for logging purposes.
Related porch issue: nephio-project/nephio#922