Helm: allow vsphere.conf to be sourced from hostPath#1677
Helm: allow vsphere.conf to be sourced from hostPath#1677skools-here wants to merge 1 commit intokubernetes:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: skools-here The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @skools-here! |
|
Hi @skools-here. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hey @chenlin07 , could you please take a look at this PR? |
|
/ok-to-test |
|
/test pull-cloud-provider-vsphere-e2e-test-on-latest-k8s-version |
What this PR does / why we need it:
Adds an optional Helm configuration to allow vsphere.conf to be sourced from a hostPath volume.
This is useful for bootstrap and constrained environments where the configuration file already exists on the node and creating a ConfigMap/Secret is not desirable. The default behavior using a ConfigMap remains unchanged.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #1460Special notes for your reviewer:
The change is fully backward compatible (config.source=configMap remains the default).
When config.source=hostPath, the ConfigMap is not created and the DaemonSet mounts the file directly from the node filesystem.
Helm validation is included to prevent misconfiguration.
Release note: