Make StartConfig listener creation context-aware#2936
Merged
aldas merged 1 commit intolabstack:masterfrom Apr 4, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2936 +/- ##
==========================================
- Coverage 93.07% 93.07% -0.01%
==========================================
Files 43 43
Lines 4506 4503 -3
==========================================
- Hits 4194 4191 -3
Misses 195 195
Partials 117 117 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tcpand wrapping TLS listeners withtls.NewListenerBenefit
StartConfig.StartandStartConfig.StartTLSalready accept a context, but listener creation previously usednet.Listenand
tls.Listen, which do not use that context. This change makes listener setup context-aware without changing how theserver behaves after the listener is created.