chore: re-publicize FDv2 data system entry points and lock entry bases#361
Merged
tanderson-ld merged 1 commit intoJun 4, 2026
Conversation
- Make Components.dataSystem() and LDConfig.Builder.dataSystem() public again so customer code can opt in to FDv2 for the EAP. PR #351 had hidden these while the surface was being finalized. - Add package-private no-arg constructors to InitializerEntry and SynchronizerEntry so external code cannot subclass them; the SDK's concrete entry types in the same package continue to compile. - Remove InternalDataSystemAccess (a pure pass-through wrapper) and switch contract-tests SdkClientEntity to call the now-public Components.dataSystem() / LDConfig.Builder.dataSystem() directly. SDK-2438
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDK-2438
Note
Medium Risk
Expands the public API for an unstable EAP data path (FDv2 vs legacy dataSource), but runtime wiring is unchanged aside from visibility and contract-test call sites.
Overview
Re-opens the early-access FDv2 data system configuration surface for customer opt-in by making
Components.dataSystem()andLDConfig.Builder.dataSystem()public again (reversing the package-private hiding from PR #351).InternalDataSystemAccessis removed as a pass-through; contract-tests now call the publicComponents.dataSystem()/builder.dataSystem(...)APIs directly.InitializerEntryandSynchronizerEntrygain package-private no-arg constructors so code outside the SDK cannot subclass those abstract bases; in-package concrete entry types (e.g. polling/streaming entries) are unchanged.Reviewed by Cursor Bugbot for commit 24eb4c0. Bugbot is set up for automated code reviews on this repo. Configure here.