fix: anchor release-please to v3.0.0 release commit#686
Closed
fix: anchor release-please to v3.0.0 release commit#686
Conversation
The Go release-type was walking the entire 698-commit history because no v3.0.0 git tag exists, causing version regression to 0.12.1. - Change release-type from "go" to "simple" to avoid Go module path conventions requiring /v3 suffix for major versions >= 2 - Add last-release-sha pointing to the 3.0.0 release commit so release-please only considers commits after that point Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the release-please version regression from 3.0.0 to 0.12.1.
Root cause: The
release-type: "go"config caused release-please to walk all 698 commits from the beginning of the repo because nov3.0.0git tag exists. The Go release-type also enforces Go module path conventions (requiring/v3suffix for major versions >= 2), which this CLI binary doesn't follow.Fix:
release-typefrom"go"to"simple"— uses the manifest as source of truth, no Go module path conventionslast-release-shapointing to the 3.0.0 release commit (caa1fd2) so release-please only considers commits after that pointAfter this merges, release-please should correctly create a 3.0.1 release PR. PR #685 (the regressed 0.12.1 PR) should be closed.
Made with Cursor
Note
Low Risk
Configuration-only change to release automation; no runtime code paths affected, but it can change how future versions/changelogs are computed.
Overview
Updates
release-please-config.jsonto switch the root packagerelease-typefromgotosimple, avoiding Go module/versioning conventions.Pins release-please’s starting point by adding
last-release-shafor thev3.0.0release commit so only commits after that SHA are considered for future release PRs.Reviewed by Cursor Bugbot for commit 0b10bc9. Bugbot is set up for automated code reviews on this repo. Configure here.