Skip to content

fix(payment): skip store insertion on routing failures to allow retry#906

Open
alexgrad42 wants to merge 1 commit into
lightningdevkit:mainfrom
alexgrad42:feature/no_store_update_for_fail_finding_route
Open

fix(payment): skip store insertion on routing failures to allow retry#906
alexgrad42 wants to merge 1 commit into
lightningdevkit:mainfrom
alexgrad42:feature/no_store_update_for_fail_finding_route

Conversation

@alexgrad42
Copy link
Copy Markdown

@alexgrad42 alexgrad42 commented May 17, 2026

Adjust the error handling for outbound payments so that when a payment fails at the pathfinding stage (e.g., RetryableSendFailure::RouteNotFound), we bypass inserting a PaymentStatus::Failed entry into the database.

Fix #903

@ldk-reviews-bot
Copy link
Copy Markdown

ldk-reviews-bot commented May 17, 2026 •
edited
Loading

I've assigned @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@alexgrad42
fix(payment): skip store insertion on routing failures to allow retry
c9d3974 
Adjust the error handling for outbound payments so that when a payment
fails at the pathfinding stage (e.g., `RetryableSendFailure::RouteNotFound`),
we bypass inserting a `PaymentStatus::Failed` entry into the database.

Fix lightningdevkit#903
@alexgrad42 alexgrad42 force-pushed the feature/no_store_update_for_fail_finding_route branch from 09c0a1f to c9d3974 Compare May 17, 2026 11:42
@alexgrad42 alexgrad42 marked this pull request as ready for review May 17, 2026 12:14
@ldk-reviews-bot ldk-reviews-bot requested a review from tnull May 17, 2026 12:15
@ldk-reviews-bot
Copy link
Copy Markdown

ldk-reviews-bot commented May 19, 2026

🔔 1st Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

benthecarman
benthecarman requested changes May 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@benthecarman benthecarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we already handle this, the test passes for me without your changes or at least the test doesn't actually cover the issue you're trying to fix

@ldk-reviews-bot
Copy link
Copy Markdown

ldk-reviews-bot commented May 21, 2026

🔔 2nd Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benthecarman benthecarman benthecarman requested changes

@tnull tnull Awaiting requested review from tnull

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Should we update payment store if we fail finding a route?

3 participants

@alexgrad42 @ldk-reviews-bot @benthecarman