Correctly refer to pay_for_offer_from_hrn in pay_for_offer docs#4540
Open
TheBlueMatt wants to merge 1 commit intolightningdevkit:mainfrom
Open
Correctly refer to pay_for_offer_from_hrn in pay_for_offer docs#4540TheBlueMatt wants to merge 1 commit intolightningdevkit:mainfrom
pay_for_offer_from_hrn in pay_for_offer docs#4540TheBlueMatt wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
|
I've assigned @wpaulino as a reviewer! |
Collaborator
|
I've reviewed the full diff and surrounding context. The prior review already caught the only issue — the missing verb "use" before No new issues found. My prior review already identified the one grammar nit in this docs-only change (missing verb "use" before |
If a `pay_for_offer` call comes in that was for an HRN, downstream code should instead call `pay_for_offer_from_hrn`, not `pay_for_offer`.
TheBlueMatt
force-pushed
the
2026-04-drop-native-dns
branch
from
fa4f1fc to
3902908
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a
pay_for_offercall comes in that was for an HRN, downstream code should instead callpay_for_offer_from_hrn, notpay_for_offer.