fuzz: count symlinked fuzz corpus files#4626
Conversation
The fuzz CI job links cloned corpus dirs into hfuzz_workspace, but plain find does not descend through those symlinked directories. Count with find -L so the iteration budget reflects the real corpus size, and fail loudly if a linked corpus resolves to zero files.
|
👋 Thanks for assigning @TheBlueMatt as a reviewer! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4626 +/- ##
==========================================
+ Coverage 86.59% 86.62% +0.02%
==========================================
Files 159 159
Lines 110420 110420
Branches 110420 110420
==========================================
+ Hits 95619 95647 +28
+ Misses 12267 12240 -27
+ Partials 2534 2533 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I've thoroughly reviewed the PR diff, the existing
No issues found. |
| local FILE=$2 | ||
| local CORPUS_COUNT=$3 | ||
|
|
||
| if [ -L "$CORPUS_DIR" ] && [ "$CORPUS_COUNT" -eq 0 ]; then |
There was a problem hiding this comment.
Feel like this should warn even if the dir isn't a link, but whatever.
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
The fuzz CI job links cloned corpus dirs into hfuzz_workspace, but plain find does not descend through those symlinked directories.
Count with find -L so the iteration budget reflects the real corpus size, and fail loudly if a linked corpus resolves to zero files.