Skip to content

notification: Limit max height and enable vscroll#13640

Open
anaximeno wants to merge 4 commits into
linuxmint:masterfrom
anaximeno:notification/set-max-min-height-and-enable-vscroll
Open

notification: Limit max height and enable vscroll#13640
anaximeno wants to merge 4 commits into
linuxmint:masterfrom
anaximeno:notification/set-max-min-height-and-enable-vscroll

Conversation

@anaximeno
Copy link
Copy Markdown
Contributor

Avoids cases where notifications would grow beyond the monitor screen height.

Before

Captura de ecrã de 2026-03-12 20-49-43

After

image

@anaximeno anaximeno changed the title notification: Limit max height and enable vscroll [WIP] notification: Limit max height and enable vscroll Mar 14, 2026
@anaximeno anaximeno force-pushed the notification/set-max-min-height-and-enable-vscroll branch from 5a12fa0 to 8306b83 Compare March 15, 2026 06:50
@anaximeno anaximeno changed the title [WIP] notification: Limit max height and enable vscroll notification: Limit max height and enable vscroll Mar 15, 2026
@mtwebster
Copy link
Copy Markdown
Member

I think this is good for a notification's initial display, but maybe the max height can be increased, or even based on some percentage of the monitor height.

Once it's in the notification applet, however, it should revert to its full size and remove the individual scrolling altogether - I think the parent being scrollable there is enough, and having both is confusing (scroll works for the outer but not the inner).

anaximeno added 2 commits May 25, 2026 23:47
…ent leaves

Fix `St:ERROR:../src/st/st-scroll-bar.c:662:handle_button_press_event_cb: assertion failed: (!priv->grab_device)
Bail out! St:ERROR:../src/st/st-scroll-bar.c:662:handle_button_press_event_cb: assertion failed: (!priv->grab_device)`, this can happen if events are lost when the scrollbar's container is hidden or removed while dragging and can trigger a full break of Cinnamon.
@anaximeno anaximeno force-pushed the notification/set-max-min-height-and-enable-vscroll branch from 8306b83 to ba1f02b Compare May 26, 2026 00:51
@anaximeno
Copy link
Copy Markdown
Contributor Author

I think this is good for a notification's initial display, but maybe the max height can be increased, or even based on some percentage of the monitor height.

Once it's in the notification applet, however, it should revert to its full size and remove the individual scrolling altogether - I think the parent being scrollable there is enough, and having both is confusing (scroll works for the outer but not the inner).

Done.

@anaximeno anaximeno marked this pull request as ready for review May 26, 2026 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants