install: create GOBIN directory if it doesn't exist#840
Open
c-tonneslan wants to merge 1 commit intolivekit:mainfrom
Open
install: create GOBIN directory if it doesn't exist#840c-tonneslan wants to merge 1 commit intolivekit:mainfrom
c-tonneslan wants to merge 1 commit intolivekit:mainfrom
Conversation
make install fails on fresh environments if GOBIN doesn't exist yet. Adding mkdir -p before the copy so it just works instead of erroring out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #818.
make installfails on fresh environments where GOBIN doesn't exist yet. Thecpjust errors out immediately. Addingmkdir -p $(GOBIN)before the copy so it works out of the box.Easy to reproduce: set
GOBINto a path that doesn't exist and runmake install.