agentfs: use forward slashes in Dockerfile entrypoint paths on Windows#842
Open
c-tonneslan wants to merge 1 commit intolivekit:mainfrom
Open
agentfs: use forward slashes in Dockerfile entrypoint paths on Windows#842c-tonneslan wants to merge 1 commit intolivekit:mainfrom
c-tonneslan wants to merge 1 commit intolivekit:mainfrom
Conversation
filepath.WalkDir returns OS-native paths, so on Windows the entrypoint ends up as something like src\agent.py in the generated Dockerfile. Since the base image is Linux, those paths are invalid at runtime. Fix by making the path relative to the project dir with filepath.Rel and converting separators with filepath.ToSlash before adding to the candidate list. This way all branches (auto-select, skip-prompts, and interactive) get a clean Unix-style path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #761.
filepath.WalkDirreturns OS-native paths, so on Windows the generated Dockerfile ends up with entries like:The base image is always Linux, so those backslash paths don't work at runtime.
Fix: when collecting candidate entrypoint files, use
filepath.Relto make the path relative to the project directory, thenfilepath.ToSlashto normalize separators. All selection branches (auto, skip-prompts, interactive) now get a clean Unix-style path likesrc/agent.py.