Update livekit-ffi to 0.12.57#667
Closed
xianshijing-lk wants to merge 2 commits into
Closed
Conversation
- Update rust-sdks submodule to latest main (497527d4) - Regenerate protobuf files - Includes: Fix LocalTrackPublished handle leak, WebRTC ADM integration, and other improvements Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Devin Review found 1 potential issue.
🐛 1 issue in files not directly in the diff
🐛 Room.connect crashes: references removed ready_for_room_event protobuf field (livekit-rtc/livekit/rtc/room.py:559-561)
The ready_for_room_event field was removed from FfiRequest in the updated protobuf definitions (replaced by new_platform_audio at the same field number in livekit-rtc/livekit/rtc/_proto/ffi_pb2.py), and ReadyForRoomEventRequest/ReadyForRoomEventResponse were also removed from room_pb2.py. However, room.py:560 still accesses ready_req.ready_for_room_event.room_handle, which will raise AttributeError at runtime. This breaks every Room.connect() call.
View 2 additional findings in Devin Review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notable changes in rust-sdks:
Test plan
🤖 Generated with Claude Code