Update livekit-ffi to 0.12.57#668
Conversation
xianshijing-lk
commented
May 15, 2026
xianshijing-lk
commented
- Update rust-sdks submodule to latest main (497527d4)
- Regenerate protobuf files
- Includes: Fix LocalTrackPublished handle leak, WebRTC ADM integration, and other improvements
- Update rust-sdks submodule to latest main (497527d4) - Regenerate protobuf files - Includes: Fix LocalTrackPublished handle leak, WebRTC ADM integration, and other improvements Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
Devin Review found 1 potential issue.
🐛 1 issue in files not directly in the diff
🐛 Protobuf field ready_for_room_event removed from FfiRequest but room.py still uses it, causing AttributeError on every connection (livekit-rtc/livekit/rtc/_proto/ffi_pb2.pyi:357-358)
The protobuf definitions were updated to replace ready_for_room_event (field 77) on FfiRequest with new_platform_audio, and ReadyForRoomEventRequest/ReadyForRoomEventResponse message types were removed from room_pb2. However, livekit-rtc/livekit/rtc/room.py:560 still does ready_req.ready_for_room_event.room_handle = self._ffi_handle.handle, which will now raise AttributeError: ready_for_room_event at runtime. This line executes during every room connection (in the connect() method), so all room connections will crash after the initial handshake succeeds. I confirmed this by running the protobuf module: FfiRequest no longer has the ready_for_room_event field and room_pb2 no longer has ReadyForRoomEventRequest.
View 2 additional findings in Devin Review.
3 participants
