Skip to content

Add volume path and clear subcommands#183

Merged
gtsiolis merged 16 commits intomainfrom
des-198-add-a-volume-path-subcommand
Apr 22, 2026
Merged

Add volume path and clear subcommands#183
gtsiolis merged 16 commits intomainfrom
des-198-add-a-volume-path-subcommand

Conversation

@gtsiolis
Copy link
Copy Markdown
Member

@gtsiolis gtsiolis commented Apr 2, 2026

This will add lstk volume command group with two subcommands:

  1. lstk volume path: prints the resolved volume directory path for each configured emulator
  2. lstk volume clear: removes all data from emulator volume directories to reset cached state
    • volume clear asks for interactive confirmation by default; requires --force in non-interactive mode
    • volume clear supports --type to target a specific emulator (e.g., --container aws)
volume path volume clear
Screenshot 2026-04-02 at 14 03 30 Screenshot 2026-04-02 at 14 03 35

Fix DES-199, DES-198

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@gtsiolis gtsiolis changed the title Add volume path command to print resolved volume directory Add volume path and clear subcommands Apr 2, 2026
@gtsiolis gtsiolis marked this pull request as draft April 2, 2026 11:01
@gtsiolis gtsiolis marked this pull request as ready for review April 2, 2026 11:07
@gtsiolis gtsiolis marked this pull request as draft April 2, 2026 11:12
@gtsiolis gtsiolis marked this pull request as ready for review April 2, 2026 11:17
Comment thread cmd/volume.go Outdated
@gtsiolis gtsiolis force-pushed the des-198-add-a-volume-path-subcommand branch from e5137df to 02e75e8 Compare April 21, 2026 14:10
@gtsiolis gtsiolis requested a review from anisaoshafi April 21, 2026 14:10
Comment thread cmd/volume.go Outdated
Comment thread test/integration/volume_test.go Outdated
Comment thread internal/volume/clear.go Outdated
Comment thread internal/ui/run_volume_clear.go
@gtsiolis
Copy link
Copy Markdown
Member Author

Could you take another look, @carole-lavillonniere?

Added also 31be41e as some tests were failing in main locally.

@carole-lavillonniere
Copy link
Copy Markdown
Collaborator

Tested locally and pushed aad62c8 for this situation:
image
@gtsiolis or @anisaoshafi can you have a look and give me a 👍 ?
As far as I understood that would only happen on linux because docker does not run containers in a VM like it does on Windows and macOS.

@gtsiolis
Copy link
Copy Markdown
Member Author

Thanks, @carole-lavillonniere! I can reproduce the bug and fix in Linux. ✔️

@gtsiolis gtsiolis merged commit 2f88982 into main Apr 22, 2026
7 checks passed
@gtsiolis gtsiolis deleted the des-198-add-a-volume-path-subcommand branch April 22, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants