fix: handle os.getlogin() OSError in keychain.py#166
Open
Dabao21 wants to merge 1 commit intolsdefine:mainfrom
Open
fix: handle os.getlogin() OSError in keychain.py#166Dabao21 wants to merge 1 commit intolsdefine:mainfrom
Dabao21 wants to merge 1 commit intolsdefine:mainfrom
Conversation
os.getlogin() raises OSError when there is no controlling terminal (e.g. systemd services, Docker containers, CI environments). This caused the entire keychain module to fail on import. Now falls back to USER/USERNAME environment variables with a default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
memory/keychain.py,os.getlogin()is called at module import time to generate the encryption mask:os.getlogin()raisesOSErrorwhen there is no controlling terminal. This happens in:When this fails, the entire
keychainmodule cannot be imported, breaking any code that depends on it.Fix
Catch
OSErrorand fall back to environment variables:USERis the standard variable on Linux/macOS,USERNAMEon Windows. The'default'fallback ensures the module always loads.Impact
keychainmodule now works in headless/CI environments