Open
Conversation
Collaborator
|
I'll pick this up once the technical review has been passed. |
Contributor
|
Approved by Team for technical review |
Collaborator
MarkvanMents
left a comment
MarkvanMents
left a comment
There was a problem hiding this comment.
@dahfjkg
Thanks for the PR Pavel. I have made one minor suggestion - let me know if you think it is an improvement or non needed?
Comment on lines
+1056
to
+1057
| 1. HSQLDB accepts values `0` to `11` | ||
| 2. Other databases accept values `1` to `12` |
Collaborator
There was a problem hiding this comment.
Should we actually use zero-based and one-based in this description to make it easier to see the difference?
Suggested change
| 1. HSQLDB accepts values `0` to `11` | |
| 2. Other databases accept values `1` to `12` | |
| 1. HSQLDB uses zero-based indexing and accepts values `0` to `11` | |
| 2. Other databases use one-based indexing and accept values `1` to `12` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires team review. To be published with Studio Pro 11.10