[WC-3428] DG2: remove margin from progress bar and pagination bar#2257
Open
yordan-st wants to merge 4 commits into
Open
[WC-3428] DG2: remove margin from progress bar and pagination bar#2257yordan-st wants to merge 4 commits into
yordan-st wants to merge 4 commits into
Conversation
- rename progress-bar class to pagination-bar in datagrid styles - fixes trampled progress bar
This comment has been minimized.
This comment has been minimized.
r0b1n
reviewed
Jun 9, 2026
This comment has been minimized.
This comment has been minimized.
r0b1n
previously approved these changes
Jun 10, 2026
yordan-st
changed the title
Neither element needs the 16px margin — removing it fully fixes the visual regression caused by the unintended CSS class name match.
yordan-st
force-pushed
the
fix/WC-3428_DG-progress-bar-margin
branch
from
5cbfc61 to
439b722
Compare
samuelreichert
approved these changes
Jun 11, 2026
iobuhov
approved these changes
Jun 12, 2026
leonardomendix
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
We removed the 16px margin from both the Progress Bar and Pagination Bar inside Data Grid. The margin was originally on the progress bar, then moved to the pagination bar in a prior fix — but neither element should have this margin. Removing it fully fixes the visual regression caused by the unintended CSS class name match.