Skip to content

[MOO-2069] Generate EditableImageValue for native images with allowUpload set to true #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saurabhchavan1711 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[MOO-2069] Generate EditableImageValue for native images with allowUpload set to true #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4920ad7
EditableImageValue<NativeImage> property added for type image for native
saurabhchavan1711 Apr 23, 2026
c6a4076
added changelogs
saurabhchavan1711 Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/pluggable-widgets-tools/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## [Unreleased]

### Added

- We added support for the `allowUpload` attribute on image properties in native widgets, generating `EditableImageValue<NativeImage>` when enabled.

### Changed

- We changed the order of imports in generated widget prop types to match that of the eslint sort-imports rule.
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggable-widgets-tools/src/typings-generator/__tests__/outputs/image.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export const imageNativeOutput = `export interface MyWidgetProps<Style> {
style: Style[];
image: DynamicValue<NativeImage>;
image2?: DynamicValue<NativeImage>;
image3: DynamicValue<NativeImage>;
image3: EditableImageValue<NativeImage>;
description: EditableValue<string>;
action?: ActionValue;
}`;
5 changes: 4 additions & 1 deletion packages/pluggable-widgets-tools/src/typings-generator/generateClientTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,10 @@ function toClientPropType(
case "icon":
return isNative ? "DynamicValue<NativeIcon>" : "DynamicValue<WebIcon>";
case "image":
return isNative ? "DynamicValue<NativeImage>" : prop.$.allowUpload === "true" ? "EditableImageValue<WebImage>" : "DynamicValue<WebImage>";
if (prop.$.allowUpload === "true") {
return isNative ? "EditableImageValue<NativeImage>" : "EditableImageValue<WebImage>";
}
return isNative ? "DynamicValue<NativeImage>" : "DynamicValue<WebImage>";
case "file":
return prop.$.allowUpload ? "EditableFileValue" : "DynamicValue<FileValue>";
case "datasource":
Expand Down
Loading