test: add mock tests for 8 executor handler files

mdl/executor/cmd_alter_page_mock_test.go

@@ -0,0 +1,310 @@
+// SPDX-License-Identifier: Apache-2.0
+
+package executor
+
+import (
+	"fmt"
+	"testing"
+
+	"github.com/mendixlabs/mxcli/mdl/ast"
+	"github.com/mendixlabs/mxcli/mdl/backend"
+	"github.com/mendixlabs/mxcli/mdl/backend/mock"
+	"github.com/mendixlabs/mxcli/mdl/types"
+	"github.com/mendixlabs/mxcli/model"
+	"github.com/mendixlabs/mxcli/sdk/pages"
+)
+
+// ---------------------------------------------------------------------------
+// Not connected
+// ---------------------------------------------------------------------------
+
+func TestAlterPage_NotConnected(t *testing.T) {
+	mb := &mock.MockBackend{IsConnectedFunc: func() bool { return false }}
+	ctx, _ := newMockCtx(t, withBackend(mb))
+	err := execAlterPage(ctx, &ast.AlterPageStmt{
+		PageName: ast.QualifiedName{Module: "M", Name: "P"},
+	})
+	assertError(t, err)
+	assertContainsStr(t, err.Error(), "not connected")
+}
+
+// ---------------------------------------------------------------------------
+// Page not found
+// ---------------------------------------------------------------------------
+
+func TestAlterPage_PageNotFound(t *testing.T) {
+	mod := mkModule("MyModule")
+	mb := &mock.MockBackend{
+		IsConnectedFunc: func() bool { return true },
+		ListModulesFunc: func() ([]*model.Module, error) { return []*model.Module{mod}, nil },
+		ListFoldersFunc: func() ([]*types.FolderInfo, error) { return nil, nil },
+		ListPagesFunc:   func() ([]*pages.Page, error) { return nil, nil },
+	}
+	h := mkHierarchy(mod)
+	ctx, _ := newMockCtx(t, withBackend(mb), withHierarchy(h))
+	err := execAlterPage(ctx, &ast.AlterPageStmt{
+		PageName: ast.QualifiedName{Module: "MyModule", Name: "Missing"},
+	})
+	assertError(t, err)
+	assertContainsStr(t, err.Error(), "not found")
+}
+
+// ---------------------------------------------------------------------------
+// Page happy path — SET property + Save
+// ---------------------------------------------------------------------------
+
+func TestAlterPage_SetProperty_Success(t *testing.T) {
+	mod := mkModule("MyModule")
+	pg := mkPage(mod.ID, "TestPage")
+	saved := false
+	setPropCalled := false
+	mb := &mock.MockBackend{
+		IsConnectedFunc: func() bool { return true },
+		ListModulesFunc: func() ([]*model.Module, error) { return []*model.Module{mod}, nil },
+		ListFoldersFunc: func() ([]*types.FolderInfo, error) { return nil, nil },
+		ListPagesFunc:   func() ([]*pages.Page, error) { return []*pages.Page{pg}, nil },
+		OpenPageForMutationFunc: func(unitID model.ID) (backend.PageMutator, error) {
+			return &mock.MockPageMutator{
+				SetWidgetPropertyFunc: func(widgetRef string, prop string, value any) error {
+					setPropCalled = true
+					if widgetRef != "myWidget" {
+						t.Errorf("expected widgetRef myWidget, got %s", widgetRef)
+					}
+					if prop != "Caption" {
+						t.Errorf("expected prop Caption, got %s", prop)
+					}
+					return nil
+				},
+				SaveFunc: func() error { saved = true; return nil },
+			}, nil
+		},
+	}
+	h := mkHierarchy(mod)
+	withContainer(h, pg.ContainerID, mod.ID)
+	ctx, buf := newMockCtx(t, withBackend(mb), withHierarchy(h))
+	assertNoError(t, execAlterPage(ctx, &ast.AlterPageStmt{
+		PageName: ast.QualifiedName{Module: "MyModule", Name: "TestPage"},
+		Operations: []ast.AlterPageOperation{
+			&ast.SetPropertyOp{
+				Target:     ast.WidgetRef{Widget: "myWidget"},
+				Properties: map[string]any{"Caption": "Hello"},
+			},
+		},
+	}))
+	if !setPropCalled {
+		t.Error("expected SetWidgetProperty to be called")
+	}
+	if !saved {
+		t.Error("expected Save to be called")
+	}
+	assertContainsStr(t, buf.String(), "Altered page")
+	assertContainsStr(t, buf.String(), "MyModule.TestPage")
+}
+
+// ---------------------------------------------------------------------------
+// Snippet happy path
+// ---------------------------------------------------------------------------
+
+func TestAlterPage_Snippet_Success(t *testing.T) {
+	mod := mkModule("MyModule")
+	snp := mkSnippet(mod.ID, "TestSnippet")
+	saved := false
+	mb := &mock.MockBackend{
+		IsConnectedFunc: func() bool { return true },
+		ListModulesFunc: func() ([]*model.Module, error) { return []*model.Module{mod}, nil },
+		ListFoldersFunc: func() ([]*types.FolderInfo, error) { return nil, nil },
+		ListSnippetsFunc: func() ([]*pages.Snippet, error) {
+			return []*pages.Snippet{snp}, nil
+		},
+		OpenPageForMutationFunc: func(unitID model.ID) (backend.PageMutator, error) {
+			return &mock.MockPageMutator{
+				SaveFunc: func() error { saved = true; return nil },
+			}, nil
+		},
+	}
+	h := mkHierarchy(mod)
+	withContainer(h, snp.ContainerID, mod.ID)
+	ctx, buf := newMockCtx(t, withBackend(mb), withHierarchy(h))
+	assertNoError(t, execAlterPage(ctx, &ast.AlterPageStmt{
+		ContainerType: "snippet",
+		PageName:      ast.QualifiedName{Module: "MyModule", Name: "TestSnippet"},
+	}))
+	if !saved {
+		t.Error("expected Save to be called")
+	}
+	assertContainsStr(t, buf.String(), "Altered snippet")
+}
+
+// ---------------------------------------------------------------------------
+// Open mutator error
+// ---------------------------------------------------------------------------
+
+func TestAlterPage_OpenMutatorError(t *testing.T) {
+	mod := mkModule("MyModule")
+	pg := mkPage(mod.ID, "TestPage")
+	mb := &mock.MockBackend{
+		IsConnectedFunc: func() bool { return true },
+		ListModulesFunc: func() ([]*model.Module, error) { return []*model.Module{mod}, nil },
+		ListFoldersFunc: func() ([]*types.FolderInfo, error) { return nil, nil },
+		ListPagesFunc:   func() ([]*pages.Page, error) { return []*pages.Page{pg}, nil },
+		OpenPageForMutationFunc: func(unitID model.ID) (backend.PageMutator, error) {
+			return nil, fmt.Errorf("lock error")
+		},
+	}
+	h := mkHierarchy(mod)
+	withContainer(h, pg.ContainerID, mod.ID)
+	ctx, _ := newMockCtx(t, withBackend(mb), withHierarchy(h))
+	err := execAlterPage(ctx, &ast.AlterPageStmt{
+		PageName: ast.QualifiedName{Module: "MyModule", Name: "TestPage"},
+	})
+	assertError(t, err)
+	assertContainsStr(t, err.Error(), "open page")
+}
+
+// ---------------------------------------------------------------------------
+// Save error
+// ---------------------------------------------------------------------------
+
+func TestAlterPage_SaveError(t *testing.T) {
+	mod := mkModule("MyModule")
+	pg := mkPage(mod.ID, "TestPage")
+	mb := &mock.MockBackend{
+		IsConnectedFunc: func() bool { return true },
+		ListModulesFunc: func() ([]*model.Module, error) { return []*model.Module{mod}, nil },
+		ListFoldersFunc: func() ([]*types.FolderInfo, error) { return nil, nil },
+		ListPagesFunc:   func() ([]*pages.Page, error) { return []*pages.Page{pg}, nil },
+		OpenPageForMutationFunc: func(unitID model.ID) (backend.PageMutator, error) {
+			return &mock.MockPageMutator{
+				SaveFunc: func() error { return fmt.Errorf("disk full") },
+			}, nil
+		},
+	}
+	h := mkHierarchy(mod)
+	withContainer(h, pg.ContainerID, mod.ID)
+	ctx, _ := newMockCtx(t, withBackend(mb), withHierarchy(h))
+	err := execAlterPage(ctx, &ast.AlterPageStmt{
+		PageName: ast.QualifiedName{Module: "MyModule", Name: "TestPage"},
+	})
+	assertError(t, err)
+	assertContainsStr(t, err.Error(), "save")
+}
+
+// ---------------------------------------------------------------------------
+// DROP widget via mutator
+// ---------------------------------------------------------------------------
+
+func TestAlterPage_DropWidget_Success(t *testing.T) {
+	mod := mkModule("MyModule")
+	pg := mkPage(mod.ID, "TestPage")
+	dropCalled := false
+	mb := &mock.MockBackend{
+		IsConnectedFunc: func() bool { return true },
+		ListModulesFunc: func() ([]*model.Module, error) { return []*model.Module{mod}, nil },
+		ListFoldersFunc: func() ([]*types.FolderInfo, error) { return nil, nil },
+		ListPagesFunc:   func() ([]*pages.Page, error) { return []*pages.Page{pg}, nil },
+		OpenPageForMutationFunc: func(unitID model.ID) (backend.PageMutator, error) {
+			return &mock.MockPageMutator{
+				DropWidgetFunc: func(refs []backend.WidgetRef) error {
+					dropCalled = true
+					if len(refs) != 1 || refs[0].Widget != "oldWidget" {
+						t.Errorf("unexpected refs: %v", refs)
+					}
+					return nil
+				},
+				SaveFunc: func() error { return nil },
+			}, nil
+		},
+	}
+	h := mkHierarchy(mod)
+	withContainer(h, pg.ContainerID, mod.ID)
+	ctx, buf := newMockCtx(t, withBackend(mb), withHierarchy(h))
+	assertNoError(t, execAlterPage(ctx, &ast.AlterPageStmt{
+		PageName: ast.QualifiedName{Module: "MyModule", Name: "TestPage"},
+		Operations: []ast.AlterPageOperation{
+			&ast.DropWidgetOp{
+				Targets: []ast.WidgetRef{{Widget: "oldWidget"}},
+			},
+		},
+	}))
+	if !dropCalled {
+		t.Error("expected DropWidget to be called")
+	}
+	assertContainsStr(t, buf.String(), "Altered page")
+}
+
+// ---------------------------------------------------------------------------
+// ADD VARIABLE
+// ---------------------------------------------------------------------------
+
+func TestAlterPage_AddVariable_Success(t *testing.T) {
+	mod := mkModule("MyModule")
+	pg := mkPage(mod.ID, "TestPage")
+	addVarCalled := false
+	mb := &mock.MockBackend{
+		IsConnectedFunc: func() bool { return true },
+		ListModulesFunc: func() ([]*model.Module, error) { return []*model.Module{mod}, nil },
+		ListFoldersFunc: func() ([]*types.FolderInfo, error) { return nil, nil },
+		ListPagesFunc:   func() ([]*pages.Page, error) { return []*pages.Page{pg}, nil },
+		OpenPageForMutationFunc: func(unitID model.ID) (backend.PageMutator, error) {
+			return &mock.MockPageMutator{
+				AddVariableFunc: func(name, dataType, defaultValue string) error {
+					addVarCalled = true
+					if name != "MyVar" || dataType != "String" || defaultValue != "hello" {
+						t.Errorf("unexpected variable: %s %s %s", name, dataType, defaultValue)
+					}
+					return nil
+				},
+				SaveFunc: func() error { return nil },
+			}, nil
+		},
+	}
+	h := mkHierarchy(mod)
+	withContainer(h, pg.ContainerID, mod.ID)
+	ctx, buf := newMockCtx(t, withBackend(mb), withHierarchy(h))
+	assertNoError(t, execAlterPage(ctx, &ast.AlterPageStmt{
+		PageName: ast.QualifiedName{Module: "MyModule", Name: "TestPage"},
+		Operations: []ast.AlterPageOperation{
+			&ast.AddVariableOp{
+				Variable: ast.PageVariable{Name: "MyVar", DataType: "String", DefaultValue: "hello"},
+			},
+		},
+	}))
+	if !addVarCalled {
+		t.Error("expected AddVariable to be called")
+	}
+	assertContainsStr(t, buf.String(), "Altered page")
+}
+
+// ---------------------------------------------------------------------------
+// SET Layout on snippet — unsupported
+// ---------------------------------------------------------------------------
+
+func TestAlterPage_SetLayout_Snippet_Unsupported(t *testing.T) {
+	mod := mkModule("MyModule")
+	snp := mkSnippet(mod.ID, "TestSnippet")
+	mb := &mock.MockBackend{
+		IsConnectedFunc: func() bool { return true },
+		ListModulesFunc: func() ([]*model.Module, error) { return []*model.Module{mod}, nil },
+		ListFoldersFunc: func() ([]*types.FolderInfo, error) { return nil, nil },
+		ListSnippetsFunc: func() ([]*pages.Snippet, error) {
+			return []*pages.Snippet{snp}, nil
+		},
+		OpenPageForMutationFunc: func(unitID model.ID) (backend.PageMutator, error) {
+			return &mock.MockPageMutator{}, nil
+		},
+	}
+	h := mkHierarchy(mod)
+	withContainer(h, snp.ContainerID, mod.ID)
+	ctx, _ := newMockCtx(t, withBackend(mb), withHierarchy(h))
+	err := execAlterPage(ctx, &ast.AlterPageStmt{
+		ContainerType: "snippet",
+		PageName:      ast.QualifiedName{Module: "MyModule", Name: "TestSnippet"},
+		Operations: []ast.AlterPageOperation{
+			&ast.SetLayoutOp{
+				NewLayout: ast.QualifiedName{Module: "M", Name: "L"},
+			},
+		},
+	})
+	assertError(t, err)
+	assertContainsStr(t, err.Error(), "not supported")
+}