Skip to content

test(catalog): add unit tests for builder pure helper functions #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ako merged 2 commits into from
Apr 22, 2026
Merged

test(catalog): add unit tests for builder pure helper functions #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9019199
test(catalog): add unit tests for builder pure helper functions
retran Apr 22, 2026
5bd8d68
test(catalog): address code review feedback from ako
retran Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
327 changes: 327 additions & 0 deletions mdl/catalog/builder_microflows_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,327 @@
// SPDX-License-Identifier: Apache-2.0

package catalog

import (
Comment thread
retran marked this conversation as resolved.
"testing"

"github.com/mendixlabs/mxcli/sdk/microflows"
"github.com/mendixlabs/mxcli/model"
)

// unknownMicroflowObject satisfies MicroflowObject but is not in the type switch.
type unknownMicroflowObject struct{}

func (u *unknownMicroflowObject) GetID() model.ID { return "" }
func (u *unknownMicroflowObject) GetPosition() model.Point { return model.Point{} }
func (u *unknownMicroflowObject) SetPosition(model.Point) {}

func TestGetMicroflowObjectType(t *testing.T) {
tests := []struct {
name string
obj microflows.MicroflowObject
want string
}{
{"ActionActivity", &microflows.ActionActivity{}, "ActionActivity"},
{"StartEvent", &microflows.StartEvent{}, "StartEvent"},
{"EndEvent", &microflows.EndEvent{}, "EndEvent"},
{"ExclusiveSplit", &microflows.ExclusiveSplit{}, "ExclusiveSplit"},
{"InheritanceSplit", &microflows.InheritanceSplit{}, "InheritanceSplit"},
{"ExclusiveMerge", &microflows.ExclusiveMerge{}, "ExclusiveMerge"},
{"LoopedActivity", &microflows.LoopedActivity{}, "LoopedActivity"},
{"Annotation", &microflows.Annotation{}, "Annotation"},
{"BreakEvent", &microflows.BreakEvent{}, "BreakEvent"},
{"ContinueEvent", &microflows.ContinueEvent{}, "ContinueEvent"},
{"ErrorEvent", &microflows.ErrorEvent{}, "ErrorEvent"},
{"unknown object falls to default", &unknownMicroflowObject{}, "MicroflowObject"},
}

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
if got := getMicroflowObjectType(tt.obj); got != tt.want {
t.Errorf("getMicroflowObjectType() = %q, want %q", got, tt.want)
}
})
}
}

func TestGetMicroflowActionType(t *testing.T) {
tests := []struct {
name string
action microflows.MicroflowAction
want string
}{
{"CreateObjectAction", &microflows.CreateObjectAction{}, "CreateObjectAction"},
{"ChangeObjectAction", &microflows.ChangeObjectAction{}, "ChangeObjectAction"},
{"RetrieveAction", &microflows.RetrieveAction{}, "RetrieveAction"},
{"MicroflowCallAction", &microflows.MicroflowCallAction{}, "MicroflowCallAction"},
{"JavaActionCallAction", &microflows.JavaActionCallAction{}, "JavaActionCallAction"},
{"ShowMessageAction", &microflows.ShowMessageAction{}, "ShowMessageAction"},
{"LogMessageAction", &microflows.LogMessageAction{}, "LogMessageAction"},
{"ValidationFeedbackAction", &microflows.ValidationFeedbackAction{}, "ValidationFeedbackAction"},
{"ChangeVariableAction", &microflows.ChangeVariableAction{}, "ChangeVariableAction"},
{"CreateVariableAction", &microflows.CreateVariableAction{}, "CreateVariableAction"},
{"AggregateListAction", &microflows.AggregateListAction{}, "AggregateListAction"},
{"ListOperationAction", &microflows.ListOperationAction{}, "ListOperationAction"},
{"CastAction", &microflows.CastAction{}, "CastAction"},
{"DownloadFileAction", &microflows.DownloadFileAction{}, "DownloadFileAction"},
{"ClosePageAction", &microflows.ClosePageAction{}, "ClosePageAction"},
{"ShowPageAction", &microflows.ShowPageAction{}, "ShowPageAction"},
{"CallExternalAction", &microflows.CallExternalAction{}, "CallExternalAction"},
{"unknown action falls to default", &microflows.UnknownAction{TypeName: "CustomThing"}, "MicroflowAction"},
}

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
if got := getMicroflowActionType(tt.action); got != tt.want {
t.Errorf("getMicroflowActionType() = %q, want %q", got, tt.want)
}
})
}
}

func TestGetDataTypeName(t *testing.T) {
tests := []struct {
name string
dt microflows.DataType
want string
}{
{"nil", nil, ""},
{"Boolean", &microflows.BooleanType{}, "Boolean"},
{"Integer", &microflows.IntegerType{}, "Integer"},
{"Long", &microflows.LongType{}, "Long"},
{"Decimal", &microflows.DecimalType{}, "Decimal"},
{"String", &microflows.StringType{}, "String"},
{"DateTime", &microflows.DateTimeType{}, "DateTime"},
{"Date", &microflows.DateType{}, "Date"},
{"Void", &microflows.VoidType{}, "Void"},
{"Object with entity", &microflows.ObjectType{EntityQualifiedName: "Module.Entity"}, "Object:Module.Entity"},
{"List with entity", &microflows.ListType{EntityQualifiedName: "Module.Entity"}, "List:Module.Entity"},
{"Enumeration", &microflows.EnumerationType{EnumerationQualifiedName: "Module.Color"}, "Enumeration:Module.Color"},
{"Binary falls to Unknown", &microflows.BinaryType{}, "Unknown"},
}

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
if got := getDataTypeName(tt.dt); got != tt.want {
t.Errorf("getDataTypeName() = %q, want %q", got, tt.want)
}
})
}
}

func TestCountMicroflowActivities(t *testing.T) {
tests := []struct {
name string
mf *microflows.Microflow
want int
}{
{
name: "nil object collection",
mf: &microflows.Microflow{},
want: 0,
},
{
name: "empty objects",
mf: &microflows.Microflow{
ObjectCollection: &microflows.MicroflowObjectCollection{},
},
want: 0,
},
{
name: "excludes start/end/merge",
mf: &microflows.Microflow{
ObjectCollection: &microflows.MicroflowObjectCollection{
Objects: []microflows.MicroflowObject{
&microflows.StartEvent{},
&microflows.ActionActivity{},
&microflows.ExclusiveSplit{},
&microflows.EndEvent{},
&microflows.ExclusiveMerge{},
},
},
},
want: 2, // ActionActivity + ExclusiveSplit
},
{
name: "counts loops and annotations",
mf: &microflows.Microflow{
ObjectCollection: &microflows.MicroflowObjectCollection{
Objects: []microflows.MicroflowObject{
&microflows.LoopedActivity{},
&microflows.Annotation{},
&microflows.ErrorEvent{},
},
},
},
want: 3,
},
}

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
if got := countMicroflowActivities(tt.mf); got != tt.want {
t.Errorf("countMicroflowActivities() = %d, want %d", got, tt.want)
}
})
}
}

func TestCalculateMcCabeComplexity(t *testing.T) {
tests := []struct {
name string
mf *microflows.Microflow
want int
}{
{
name: "nil object collection — base complexity",
mf: &microflows.Microflow{},
want: 1,
},
{
name: "no decision points",
mf: &microflows.Microflow{
ObjectCollection: &microflows.MicroflowObjectCollection{
Objects: []microflows.MicroflowObject{
&microflows.StartEvent{},
&microflows.ActionActivity{},
&microflows.EndEvent{},
},
},
},
want: 1,
},
{
name: "exclusive split adds 1",
mf: &microflows.Microflow{
ObjectCollection: &microflows.MicroflowObjectCollection{
Objects: []microflows.MicroflowObject{
&microflows.ExclusiveSplit{},
},
},
},
want: 2,
},
{
name: "inheritance split adds 1",
mf: &microflows.Microflow{
ObjectCollection: &microflows.MicroflowObjectCollection{
Objects: []microflows.MicroflowObject{
&microflows.InheritanceSplit{},
},
},
},
want: 2,
},
{
name: "loop adds 1 plus nested decisions",
mf: &microflows.Microflow{
ObjectCollection: &microflows.MicroflowObjectCollection{
Objects: []microflows.MicroflowObject{
&microflows.LoopedActivity{
ObjectCollection: &microflows.MicroflowObjectCollection{
Objects: []microflows.MicroflowObject{
&microflows.ExclusiveSplit{},
},
},
},
},
},
},
want: 3, // 1 base + 1 loop + 1 nested split
},
{
name: "error event adds 1",
mf: &microflows.Microflow{
ObjectCollection: &microflows.MicroflowObjectCollection{
Objects: []microflows.MicroflowObject{
&microflows.ErrorEvent{},
},
},
},
want: 2,
},
{
name: "complex flow",
mf: &microflows.Microflow{
ObjectCollection: &microflows.MicroflowObjectCollection{
Objects: []microflows.MicroflowObject{
&microflows.ExclusiveSplit{},
&microflows.ExclusiveSplit{},
&microflows.InheritanceSplit{},
&microflows.LoopedActivity{},
&microflows.ErrorEvent{},
},
},
},
want: 6, // 1 + 2 splits + 1 inheritance + 1 loop + 1 error
},
}

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
if got := calculateMcCabeComplexity(tt.mf); got != tt.want {
t.Errorf("calculateMcCabeComplexity() = %d, want %d", got, tt.want)
}
})
}
}

func TestCountNanoflowActivities(t *testing.T) {
tests := []struct {
name string
nf *microflows.Nanoflow
want int
}{
{
name: "nil object collection",
nf: &microflows.Nanoflow{},
want: 0,
},
{
name: "excludes structural elements",
nf: &microflows.Nanoflow{
ObjectCollection: &microflows.MicroflowObjectCollection{
Objects: []microflows.MicroflowObject{
&microflows.StartEvent{},
&microflows.ActionActivity{},
&microflows.EndEvent{},
&microflows.ExclusiveMerge{},
},
},
},
want: 1, // only ActionActivity
},
}

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
if got := countNanoflowActivities(tt.nf); got != tt.want {
t.Errorf("countNanoflowActivities() = %d, want %d", got, tt.want)
}
})
}
}

func TestCalculateNanoflowComplexity(t *testing.T) {
nf := &microflows.Nanoflow{
ObjectCollection: &microflows.MicroflowObjectCollection{
Objects: []microflows.MicroflowObject{
&microflows.ExclusiveSplit{},
&microflows.LoopedActivity{
ObjectCollection: &microflows.MicroflowObjectCollection{
Objects: []microflows.MicroflowObject{
&microflows.InheritanceSplit{},
},
},
},
},
},
}

got := calculateNanoflowComplexity(nf)
want := 4 // 1 base + 1 split + 1 loop + 1 nested inheritance
if got != want {
t.Errorf("calculateNanoflowComplexity() = %d, want %d", got, want)
}
}
27 changes: 27 additions & 0 deletions mdl/catalog/builder_modules_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
// SPDX-License-Identifier: Apache-2.0

package catalog

import "testing"

func TestExtractAttrName(t *testing.T) {
tests := []struct {
name string
input string
want string
}{
{"three parts", "Module.Entity.Attribute", "Attribute"},
{"four parts", "Module.Entity.Attribute.Sub", "Sub"},
{"two parts", "Module.Entity", ""},
{"single part", "Single", ""},
{"empty string", "", ""},
}

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
if got := extractAttrName(tt.input); got != tt.want {
t.Errorf("extractAttrName(%q) = %q, want %q", tt.input, got, tt.want)
}
})
}
}
Loading
Loading