aioble/server: Log warning on out-of-order indication.#461
Open
andrewleech wants to merge 2 commits intomicropython:masterfrom
Open
aioble/server: Log warning on out-of-order indication.#461andrewleech wants to merge 2 commits intomicropython:masterfrom
andrewleech wants to merge 2 commits intomicropython:masterfrom
Conversation
andrewleech
force-pushed
the
indication_warning
branch
from
8254f6b to
7e88b98
Compare
andrewleech
force-pushed
the
indication_warning
branch
from
7e88b98 to
916b9e1
Compare
Early-return with a warning if the BLE stack fires an indication-done callback for a characteristic that doesn't have the indicate flag set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The assert in indicate_done has the potential to crash an application when indication mis-behave or were not expected.
In our experience it's been safer to just ignore and log these rather than throw an exception that cannot be easily caught.