Add JSX children note to TypeScript 5.8 release notes#3576
Open
KirtiRamchandani wants to merge 1 commit into
Open
Add JSX children note to TypeScript 5.8 release notes#3576KirtiRamchandani wants to merge 1 commit into
KirtiRamchandani wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TypeScript 5.8 changed how JSX children are checked under the automatic JSX runtimes, but the 5.8 release notes do not mention the behavior change. This leaves JSX library authors without an upgrade note when
childrenneeds to be declared explicitly in their props.Root cause
The TypeScript change in microsoft/TypeScript#60880 made
react-jsxandreact-jsxdevtype checking match the emitted runtime behavior: JSX children are passed through achildrenprop, andJSX.ElementChildrenAttributeis no longer used to choose a different prop name for those runtimes.Solution
Add a short “Notable Behavioral Changes” entry to the TypeScript 5.8 release notes explaining the behavior and showing the shape JSX typings should include when elements accept children.
Tests
git diff --check -- "packages/documentation/copy/en/release-notes/TypeScript 5.8.md"Fixes microsoft/TypeScript#63212.