CHORE: Upgrade bundled ODBC driver from 18.5.1.1 to 18.6.2.1#569
Conversation
📊 Code Coverage Report
Diff CoverageDiff: main...HEAD, staged and unstaged changes
Summary
📋 Files Needing Attention📉 Files with overall lowest coverage (click to expand)mssql_python.pybind.build._deps.simdutf-src.src.haswell.implementation.cpp: 0.4%
mssql_python.pybind.build._deps.simdutf-src.src.implementation.cpp: 6.7%
mssql_python.pybind.build._deps.simdutf-src.include.simdutf.implementation.h: 10.4%
mssql_python.pybind.build._deps.simdutf-src.include.simdutf.scalar.utf16_to_utf8.utf16_to_utf8.h: 25.3%
mssql_python.pybind.logger_bridge.cpp: 59.2%
mssql_python.pybind.ddbc_bindings.h: 59.7%
mssql_python.pybind.build._deps.simdutf-src.include.simdutf.internal.isadetection.h: 65.3%
mssql_python.row.py: 70.5%
mssql_python.pybind.logger_bridge.hpp: 70.8%
mssql_python.pybind.ddbc_bindings.cpp: 74.2%🔗 Quick Links
|
There was a problem hiding this comment.
Pull request overview
Upgrades the bundled Microsoft ODBC Driver for SQL Server from 18.5.1.1 to 18.6.2.1 across all supported platforms (Windows x64/x86/arm64, macOS x86_64/arm64, Linux debian_ubuntu/rhel/alpine/suse for x86_64 and arm64). Updates the binary references, CI download URLs/verification commands, and license/release-notes files that ship with the wheel.
Changes:
- Update Linux
.sofilename fromlibmsodbcsql-18.5.so.1.1tolibmsodbcsql-18.6.so.2.1inddbc_bindings.cpp,test_000_dependencies.py,build.sh, and the pipelinelddchecks. - Update PR validation pipeline to download the new MSI (linkid 2358430) and the new Alpine
msodbcsql18_18.6.2.1-1APKs/signatures (new download path0b3d5518-...). - Replace bundled Windows/macOS/Linux license files and macOS/Linux release-notes for the new driver version, and add a new license file for
linux/suse/x86_64.
Reviewed changes
Copilot reviewed 18 out of 53 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| mssql_python/pybind/ddbc_bindings.cpp | Updates Linux driver .so filename in GetDriverPathCpp. |
| mssql_python/pybind/build.sh | Updates patchelf example comment to new .so name. |
| tests/test_000_dependencies.py | Updates expected driver .so filename in three locations. |
| eng/pipelines/pr-validation-pipeline.yml | Updates MSI/APK URLs, package filenames, and ldd paths to 18.6.2.1; trailing blank lines added. |
| mssql_python/libs/windows/{x64,x86,arm64}/MICROSOFT_ODBC_DRIVER_FOR_SQL_SERVER_LICENSE.txt | Updated EULA text — but all non-ASCII chars are mojibake (�). |
| mssql_python/libs/macos/{x86_64,arm64}/lib/MICROSOFT_ODBC_DRIVER_FOR_SQL_SERVER_LICENSE.txt | Same EULA mojibake issue. |
| mssql_python/libs/macos/{x86_64,arm64}/share/doc/msodbcsql18/RELEASE_NOTES | Prepends 18.6.x changelog entries. |
| mssql_python/libs/linux/alpine/arm64/lib/MICROSOFT_ODBC_DRIVER_FOR_SQL_SERVER_LICENSE.txt | Updated EULA text — non-ASCII chars are mojibake. |
| mssql_python/libs/linux/alpine/x86_64/lib/MICROSOFT_ODBC_DRIVER_FOR_SQL_SERVER_LICENSE.txt | Content replaced with RELEASE_NOTES changelog instead of EULA. |
| mssql_python/libs/linux/rhel/{x86_64,arm64}/lib/MICROSOFT_ODBC_DRIVER_FOR_SQL_SERVER_LICENSE.txt | Content replaced with RELEASE_NOTES changelog instead of EULA. |
| mssql_python/libs/linux/debian_ubuntu/{x86_64,arm64}/lib/MICROSOFT_ODBC_DRIVER_FOR_SQL_SERVER_LICENSE.txt | Content replaced with RELEASE_NOTES changelog instead of EULA. |
| mssql_python/libs/linux/suse/x86_64/lib/MICROSOFT_ODBC_DRIVER_FOR_SQL_SERVER_LICENSE.txt | New file; EULA text with the same mojibake issue. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a7d4057 to
72e52f1
Compare
710e464 to
bbae95a
Compare
bewithgaurav
left a comment
There was a problem hiding this comment.
checked all 53 files. binary swaps look right across all 6 platform/arch combos, pipeline download URLs and ldd paths all point at 18.6.2.1, ddbc_bindings.cpp driver path on linux updated, tests match. one stale 18.5 reference in the pipeline but it's in a commented-out block (line 2311), not worth touching. encoding fix for the license files landed clean in the follow-up commits, french text and smart quotes render correctly in UTF-8. 100% diff coverage on the one code line. all 28 CI checks green. lgtm.
Work Item / Issue Reference
Summary
This pull request updates the project to use Microsoft ODBC Driver 18.6.2.1 for SQL Server instead of 18.5.x and updates the associated license file. The changes ensure that all references, downloads, and verifications in the CI pipeline are aligned with the new driver version, and the license file includes additional clarifications and regional information.
ODBC Driver Version Update:
eng/pipelines/pr-validation-pipeline.ymlto use ODBC Driver 18.6.2.1 instead of 18.5.x for all supported platforms and architectures. [1] [2] [3] [4] [5] [6] [7] [8] [9]License File Update:
MICROSOFT_ODBC_DRIVER_FOR_SQL_SERVER_LICENSE.txt, including more detailed distribution rights, restrictions, and limitations, as well as additional regional variations and French translations for Canadian users. [1] [2] [3]