Skip to content

fix(0.81, ci): ensure PR gate job fails instead of skipping when upstream jobs fail#2927

Merged
Saadnajmi merged 1 commit intomicrosoft:0.81-stablefrom
Saadnajmi:fix/pr-gate-always-run-0.81
Apr 16, 2026
Merged

fix(0.81, ci): ensure PR gate job fails instead of skipping when upstream jobs fail#2927
Saadnajmi merged 1 commit intomicrosoft:0.81-stablefrom
Saadnajmi:fix/pr-gate-always-run-0.81

Conversation

@Saadnajmi
Copy link
Copy Markdown
Collaborator

Summary

  • The PR gate job is the required status check for merging
  • Without if: always(), when any dependency job fails, the gate job gets skipped — and GitHub treats SKIPPED as passing for required checks, allowing PRs with failing CI to merge
  • Adds if: always() so the gate job always runs, plus an explicit check that fails when any dependency failed or was cancelled

Test plan

  • Verify that when all jobs pass, the PR gate job still passes
  • Verify that when any job fails, the PR gate job now fails instead of being skipped

🤖 Generated with Claude Code

…obs fail

Without `if: always()`, the PR gate job gets skipped when any dependency
fails. GitHub treats skipped as passing for required status checks,
allowing PRs with failing CI to be merged.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@Saadnajmi Saadnajmi requested a review from a team as a code owner April 16, 2026 18:49
@Saadnajmi Saadnajmi merged commit 3e73ef9 into microsoft:0.81-stable Apr 16, 2026
25 checks passed
@Saadnajmi Saadnajmi deleted the fix/pr-gate-always-run-0.81 branch April 16, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants