fix: don't require @react-native-community/cli at config-load time#2973
Open
gabrieldonadel wants to merge 2 commits into
Open
fix: don't require @react-native-community/cli at config-load time#2973gabrieldonadel wants to merge 2 commits into
gabrieldonadel wants to merge 2 commits into
Conversation
gabrieldonadel
force-pushed
the
@gabrieldonadel/rnc-optional-peer
branch
from
ac26ba8 to
5a73ee1
Compare
gabrieldonadel
force-pushed
the
@gabrieldonadel/rnc-optional-peer
branch
from
5a73ee1 to
a20e0ac
Compare
tido64
reviewed
Jun 4, 2026
Comment on lines
+94
to
+99
| } catch { | ||
| if (verbose) { | ||
| console.warn( | ||
| '@react-native-community/cli not found, the react-native.config.js may be unusable.', | ||
| ); | ||
| } |
Member
There was a problem hiding this comment.
Can we log the actual error message instead? There are several things that can go wrong inside runMacOS.
We should also add a comment about Expo here otherwise the next person will not know why we have this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In theory,
@react-native-community/clishould be an optional dependency, but currently therunMacOScommands import requires@react-native-community/clidirectly, causing Expo CLI users to also have to install@react-native-community/cliThis PR guards the
requirethe same way as the platform packages, and only attaches the commands when the import succeeds. The runtime behavior for projects that do install the CLI is unchanged.Test Plan:
@react-native-community/cli(e.g. an Expo app usingexpo-modules-autolinking), runpod installand confirmuse_native_modules!no longer throws when loadingreact-native.config.js.@react-native-community/cli, confirmnpx react-native run-macosand the other macOS commands still register and work as before.DEBUG=*set, confirm the new warning (./local-cli/runMacOS/runMacOS not found, the react-native.config.js may be unusable.) is emitted only when the require fails, matching the existing warnings for the other platform packages.