Add configuration options for modal editor dimensions#306882
Open
mrleemurray wants to merge 5 commits intomainfrom
Open
Add configuration options for modal editor dimensions#306882mrleemurray wants to merge 5 commits intomainfrom
mrleemurray wants to merge 5 commits intomainfrom
Conversation
…ault values Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds configurable minimum dimensions for the modal editor overlay and wires them into the modal editor sizing logic, with tailored defaults for the Sessions window experience.
Changes:
- Registers new settings:
workbench.editor.modalMinWidthandworkbench.editor.modalMinHeight. - Refactors
ModalEditorPartto derive minimum sizing constraints from configuration (and to use the width value for sidebar clamping). - Overrides default values for these settings in the Sessions window default configuration.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/vs/workbench/browser/workbench.contribution.ts | Adds configuration schema entries for modal min width/height. |
| src/vs/workbench/browser/parts/editor/modalEditorPart.ts | Uses the new configuration values to set modal min size and sidebar resizing limits. |
| src/vs/sessions/contrib/configuration/browser/configuration.contribution.ts | Sets Sessions window defaults for the new modal sizing settings. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
Yoyokrazy
approved these changes
Mar 31, 2026
bpasero
requested changes
Mar 31, 2026
Member
bpasero
left a comment
There was a problem hiding this comment.
I do not understand the need for this, esp. why a user should configure this. An editor should be able to declare its preferred min width (we already have that infrastructure in place) and then the modal editor respecting that.
Lets not do this for now, lets focus on P0s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce configuration options for setting minimum width and height of the modal editor overlay. Refactor existing code to utilize these new settings, ensuring a more flexible and customizable user experience.
Before

After
