fix: correct OS_ID parsing for quoted values in /etc/os-release#306993
Open
hellozzm wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: correct OS_ID parsing for quoted values in /etc/os-release#306993hellozzm wants to merge 1 commit intomicrosoft:mainfrom
hellozzm wants to merge 1 commit intomicrosoft:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #232159
check-requirements-linux.shusesgrep -Eo 'ID=([^"]+)'to extract the OS ID from/etc/os-release. This fails when the file contains quoted values likeID="rocky"(common on Rocky Linux 8.5+), producing an empty string and causing the script to behave incorrectly.Changes
grep -Eo+sedpipeline withsource /etc/os-release && echo $ID, which correctly handles both quoted and unquoted values.Testing
source /etc/os-release && echo $IDcorrectly extracts the ID regardless of quoting style./etc/os-releaseformat guarantees shell-safe values, so sourcing is safe here.