use NtSetInformationFile if os.Rename fails#220
Open
karman-docker wants to merge 1 commit into
Open
Conversation
Signed-off-by: Manju Karikatti <manju.karikatti@docker.com>
karman-docker
force-pushed
the
add_retry_for_rename
branch
from
477163b to
f141cb9
Compare
kolyshkin
reviewed
May 29, 2026
|
|
||
| import "os" | ||
|
|
||
| func atomicwriterRenameAt(oldpath, newpath string) error { |
Collaborator
There was a problem hiding this comment.
nit: stuttering
Also, why is it called rename At? Usually 'At' implies there's an dirfd provided, which is not the case.
Collaborator
|
This obviously needs some windows-specific tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
atomicwriterRenameAtwhich usesNtSetInformationFileto rename a file on Windows.