Rails 5 support#7
Conversation
| spec.add_dependency 'activesupport', '~> 4.1' | ||
| spec.add_dependency 'rest-client' | ||
| spec.add_dependency 'json', '>= 1.8' | ||
| spec.add_dependency 'activesupport', '>= 4.1' |
There was a problem hiding this comment.
@chrisbutler I think the build here is failing b/c these dependencies were added twice:
spec.add_dependency 'activesupport', '>= 4.1'
spec.add_dependency 'rest-client', '>= 1.7'
- Locking the json to an old version seems uneccessary - Forcing multi_json and json_pure monkeypatching broke our test suite - removed the json_pure and so far so good
|
@jamesdbloom i made the fix @AJMiller pointed out, and everything is passing now. any chance we can get this merged in? |
|
Closing as this PR is 8 years old and Rails 5 reached end-of-life in 2023 (current version is Rails 8). The Ruby client will be fully regenerated from the OpenAPI specification as part of monorepo consolidation, which will ensure compatibility with current Ruby and Rails versions. Thank you for your contribution @chrisbutler! See https://github.com/mock-server/mockserver for ongoing work. |
|
Tracking issue created: mock-server/mockserver-monorepo#2051 Rails compatibility will be verified during Ruby client regeneration. Thank you for highlighting this need! |
4 participants
hey @jamesdbloom, sorry for creating another PR (#6) but someone here accidentally deleted our fork of your repo
let me know if this PR needs any changes... it would be great to be able to switch back to using a version of your gem instead of a branch of someone else's fork!