feat: Session ID ASCII validation check#206
Merged
pcarleton merged 3 commits intomodelcontextprotocol:mainfrom Apr 13, 2026
Merged
feat: Session ID ASCII validation check#206pcarleton merged 3 commits intomodelcontextprotocol:mainfrom
pcarleton merged 3 commits intomodelcontextprotocol:mainfrom
Conversation
commit: |
pcarleton
approved these changes
Apr 13, 2026
Member
pcarleton
left a comment
There was a problem hiding this comment.
this looks great, thanks!
I've been putting spec references in a single file for client tests, but we haven't done that for servers yet. may make sense to centralize if we find this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #197
Motivation and Context
Closes a small but meaningful gap in spec coverage (a MUST).
How Has This Been Tested?
New unit tests.
Ran against modelcontextprotocol/typescript-sdk:
Breaking Changes
None
Types of changes
Checklist