PYTHON-5745 Consolidate command logging and monitoring logic#2822
Draft
blink1073 wants to merge 6 commits into
Draft
PYTHON-5745 Consolidate command logging and monitoring logic#2822blink1073 wants to merge 6 commits into
blink1073 wants to merge 6 commits into
Conversation
blink1073
changed the title
blink1073
commented
May 28, 2026
| try: | ||
| result = await bwc.conn.unack_write(msg, max_doc_size) # type: ignore[func-returns-value, misc, override] | ||
| duration = datetime.datetime.now() - bwc.start_time | ||
| if result is not None: |
Member
Author
There was a problem hiding this comment.
A note about this block and the equivalent in client_bulk.py: unack_write always returns None so there will never be a result. The spec says that we always need to emit a log, so this logic was incorrect before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[PYTHON-5745]
Changes in this PR
Introduces
pymongo/_telemetry.pywith a_CommandTelemetrycontext manager that unifies debug logging and APM event publishing into a single call site, eliminating duplicated telemetry blocks at each command call site. This is a prerequisite for PYTHON-5052 (OpenTelemetry support).Based on the spike in #2720.
Test Plan
just typingpassesjust lintpassesChecklist
Checklist for Author
Checklist for Reviewer