test(NODE-5517): display installed deps in CI#4948
Merged
Conversation
johnmtll
force-pushed
the
NODE-5517/always-log-dependencies-in-tests
branch
2 times, most recently
from
f957151 to
5c1c5cc
Compare
johnmtll
force-pushed
the
NODE-5517/always-log-dependencies-in-tests
branch
from
5c1c5cc to
8c3c4c7
Compare
Contributor
PavelSafronov
left a comment
PavelSafronov
left a comment
There was a problem hiding this comment.
Looks like the following variants don't get these logs:
Think we can/should support these?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
Adds a prefire test hook to mocha which is called whenever a mocha test is invoked. The hook simply logs all installed dependencies via
npm ls. This solves an issue described in NODE-5517 which highlights that, even though we already do dependency logging in our install scripts, we may have steps between installs & test runs which surface new dependencies we should have visibility of in CI logs.This should cover gaps without necessitating changing many ci scripts.
Notes for Reviewers
What is the motivation for this change?
Release Highlight
CI tests updated to always print installed dependencies in logs.
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript