fix: color picker for ios devices (@d1rshan)#8049
Open
d1rshan wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
the
waiting for review
d1rshan
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the theme color picker UI to remove the imperative ref/click wiring and instead make the native <input type="color"> overlay the palette button for direct interaction.
Changes:
- Removed the
colorInputRefandButtononClickthat programmatically triggered the color input. - Switched the wrapper layout from
gridtorelative+ absolutely positioned color input overlay.
github-actions
Bot
removed
the
waiting for review
github-actions
Bot
added
the
waiting for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #8048
The color picker previously relied on a click behavoiur through a ref but this could prevent the native color picker from opening on iOS.
now the color input is overlayed on top of the button, so the interaction is now handled directly by the input, which means the previous ref handling is not required anymore.
vid.mp4