Skip to content

Bug 2041810 - populate conflict_slug on mobile#7367

Open
moibra05 wants to merge 1 commit into
mozilla:mainfrom
moibra05:bugfix/missing_conflig_slug_for_mobile
Open

Bug 2041810 - populate conflict_slug on mobile#7367
moibra05 wants to merge 1 commit into
mozilla:mainfrom
moibra05:bugfix/missing_conflig_slug_for_mobile

Conversation

@moibra05
Copy link
Copy Markdown
Contributor

@moibra05 moibra05 commented May 12, 2026

Added a proper value for conflict_slug when constructing the EnrollmentStatusExtraDef taken by pulling out the actual feature slug which caused the conflict

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Copy link
Copy Markdown
Member

@freshstrangemusic freshstrangemusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes to types that are serialized to the database require tests and (in this case) a migration

Comment thread components/nimbus/src/tests/test_enrollment_bw_compat.rs Outdated
@freshstrangemusic
Copy link
Copy Markdown
Member

Your PR title should be of the form Bug XXX - description
If there is only a JIRA ticket for the issue, please file a bugzilla ticket with the same contents and set the following fields:

whiteboard: [nimbus]
see-also: (the JIRA URL)

There is a typo in your PR title: config_slug vs conflict_slug

@moibra05 moibra05 changed the title fix(nimbus): populate config_slug on mobile Bug 2041810 - populate config_slug on mobile May 22, 2026
@moibra05 moibra05 changed the title Bug 2041810 - populate config_slug on mobile Bug 2041810 - populate conflict_slug on mobile May 22, 2026
@moibra05 moibra05 force-pushed the bugfix/missing_conflig_slug_for_mobile branch from 41723b8 to e61b9e3 Compare June 2, 2026 20:04
@mergify mergify Bot dismissed freshstrangemusic’s stale review June 2, 2026 20:05

The pull request has been modified, dismissing previous reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants