Skip to content

fix(oc-capability): uses correct room field types#16781

Open
alperozturk96 wants to merge 2 commits intomasterfrom
fix/oc-capability-entry-type
Open

fix(oc-capability): uses correct room field types#16781
alperozturk96 wants to merge 2 commits intomasterfrom
fix/oc-capability-entry-type

Conversation

@alperozturk96
Copy link
Copy Markdown
Collaborator

@alperozturk96 alperozturk96 commented Mar 30, 2026

Fixes

forbiddenFileNameCharacters, forbiddenFileNames, forbiddenFileNameExtensions, forbiddenFilenameBaseNames

This PR fixes an inconsistency where several capabilities columns were defined as INTEGER in Room but actually stored JSON String values.

Why it previously worked

Data was read via cursor (getString), bypassing Room’s type mapping

Changes

Updated affected fields in CapabilityEntity from Int? to String?
Added a migration that drops the capabilities table to ensure a clean schema
Adds capability dao and mapping between entity and OCCapability

@github-actions
Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/23749644834/artifacts/6180479612
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the fix/oc-capability-entry-type branch from efc5183 to 558ed56 Compare April 8, 2026 07:08
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

APK file: https://github.com/nextcloud/android/actions/runs/24122694656/artifacts/6322219923
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

Codacy

SpotBugs

CategoryBaseNew
Bad practice3636
Correctness6969
Dodgy code229229
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3434
Performance4242
Security1616
Total436436

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants