fix: read stackId from request body in CardApiController reorder#7948
Closed
guangningsun wants to merge 1 commit into
Closed
fix: read stackId from request body in CardApiController reorder#7948guangningsun wants to merge 1 commit into
guangningsun wants to merge 1 commit into
Conversation
The Deck API reorder endpoint was ignoring the stackId in the request
body because Nextcloud's ApiController maps route parameters to method
parameters with matching names. Since the URL contains {stackId} as a
route parameter (the source stack), that value was taking precedence
over any stackId in the request body.
Now we read stackId from the raw request body (php://input), allowing
cards to be moved between stacks via the REST API.
Fixes: nextcloud#7933
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: CardApiController reorder() ignores request body stackId
Issue: #7933
The
reorder()method inCardApiController.phpreceives$stackIdas a route parameter, but the actual target stack is passed in the request body. When the API is called with{"stackId": 37, "order": 0}, the card stays in its original stack.Root Cause:
Fix: Read
stackIdfrom the request body viaphp://inputwhen the card needs to move to a different stack.Testing:
PUT /stacks/36/cards/{id}/reorderwith{"stackId": 37, "order": 0}Closes #7933