fix(user_ldap): fix lastLogin reading wrong appid and configkey#59415
Merged
susnux merged 1 commit intonextcloud:masterfrom Apr 3, 2026
Merged
Conversation
hamidout
requested review from
Altahrim,
icewind1991,
nfebe and
provokateurin
and removed request for
a team
Contributor
|
/backport to stable33 |
susnux
approved these changes
Apr 3, 2026
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Thank you so much for looking into this!
The error message is so unrelated and confusing...
Contributor
|
@hamidout to be able to merge your PR we need you to sign-off your commit, see: You can do so by e.g. |
solracsf
approved these changes
Apr 3, 2026
fetchDetails() was calling getValueInt($uid, 'user_ldap', 'email') instead of getValueInt($uid, 'login', 'lastLogin'), causing lastLogin to always return 0 for offline LDAP users. Fixes nextcloud#58421 Signed-off-by: hamid <hamid@webpick.net>
hamidout
force-pushed
the
fix/user-ldap-last-login-config-key
branch
from
6aaa258 to
b7d6822
Compare
susnux
approved these changes
Apr 3, 2026
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #58421
Summary
fetchDetails()inOfflineUserwas using the wrong appid (user_ldap) and key (email) when readinglastLoginviagetValueInt(). The value is stored under appidloginwith keylastLogin(as written byUser::updateLastLoginTimestamp()), so this always returned 0 for offline LDAP users.TODO
Checklist
AI (if applicable)