fix(http): avoid iconv for header ascii fallback#60649
Merged
Merged
Conversation
Contributor
Is it worth documenting somewhere for devs? |
Member
Author
|
I think so, just don't yet know where to put it. |
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
Member
Author
|
#60655 to prevent another re-introduction |
ChristophWurst
requested review from
a team,
SebastianKrupinski and
hamza221
as code owners
ChristophWurst
requested review from
ArtificialOwl,
come-nc,
leftybournes and
provokateurin
and removed request for
a team
ChristophWurst
added
3. to review
10 tasks
ArtificialOwl
approved these changes
May 22, 2026
iconv transliteration is locale- and config-dependent and fails silently on some setups. UnicodeString::ascii() from symfony/string uses a built-in transliteration table backed by symfony/polyfill-intl-normalizer, so it works on all setups without requiring optional PHP extensions. Assisted-by: Claude:claude-sonnet-4-6 Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
ChristophWurst
force-pushed
the
worktree-fix-content-disposition
branch
from
919077c to
d1d24e6
Compare
Antreesy
approved these changes
May 22, 2026
ChristophWurst
added
4. to release
hamza221
approved these changes
May 22, 2026
SebastianKrupinski
approved these changes
May 22, 2026
Member
Author
|
CI failures unrelated |
This was referenced May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
iconv transliteration is locale- and config-dependent and fails silently on some setups. UnicodeString::ascii() from symfony/string uses a built-in transliteration table backed by symfony/polyfill-intl-normalizer, so it works on all setups without requiring optional PHP extensions.
#29470 removed iconv, I brought it back with #59843 🙈
TODO
content-disposition: attachment; filename=Tast; filename*=utf-8''T%C3%A4st-> ASCII fallback isTast✔️Checklist
3. to review, feature component)stable32)AI (if applicable)