Split proxy into multiple header files#42
Merged
Conversation
tian-lt-personal
approved these changes
Jun 14, 2026
mingxwa
added a commit
to mingxwa/proxy
that referenced
this pull request
Jun 15, 2026
Port the arm64e pointer-authentication hardening from user/mingxwa/pac-3 onto main's multi-header layout (ngcpp#42). proxy's hand-rolled v-table -- invoker, composite_meta, meta_storage -- moves into a new detail/facade_meta_traits.h, which carries a signed implementation on PAC targets (PRO4D_PAC) and a plain constexpr one elsewhere. core.h includes it in place of the old conv_meta/composite_meta/meta_ptr machinery and feeds a std::tuple of metas to meta_storage. The signed-pointer helpers code_ptr/data_ptr are inlined directly into invoker (the IA-signed function pointer) and meta_storage (the DA-signed v-table pointer); both expose has_value()/reset() so the inline meta_storage specialization is shared between the two implementations. Validated the non-PAC path locally (full test suite); the arm64e path is exercised by the new bvt-apple-pac CI job. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
mingxwa
added a commit
to mingxwa/proxy
that referenced
this pull request
Jun 15, 2026
Port the arm64e pointer-authentication hardening from user/mingxwa/pac-3 onto main's multi-header layout (ngcpp#42). proxy's hand-rolled v-table -- invoker, composite_meta, meta_storage -- moves into a new detail/facade_meta_traits.h, which carries a signed implementation on PAC targets (PRO4D_PAC) and a plain constexpr one elsewhere. core.h includes it in place of the old conv_meta/composite_meta/meta_ptr machinery and feeds a std::tuple of metas to meta_storage. The signed-pointer helpers code_ptr/data_ptr are inlined directly into invoker (the IA-signed function pointer) and meta_storage (the DA-signed v-table pointer); both expose has_value()/reset() so the inline meta_storage specialization is shared between the two implementations. Validated the non-PAC path locally (full test suite); the arm64e path is exercised by the new bvt-apple-pac CI job. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As more features getting added to the library, managing everything inside a single
proxy.his no longer scalable. It's time to split it.Changes
proxy.hinto 5 different headers indetail:core.h: Full implementation of P3086proxy_creation.h: Full implementation of P3401facade_creation.h: Full implementation of P3584dispatch.h:operator_dispatch,conversion_dispatch,weak_dispatch, etc.skills.h:skills::format,skills::as_view,skills::rtti, etc.detailstodetail.instantiated_t(which doesn't really instantiate a class template) intospecialization_t.proxyheader files systematically.No functional changes