Add Lentient flag that prohibits 0 hosts or multiple.#825
Draft
Vizonex wants to merge 2 commits intonodejs:mainfrom
Draft
Add Lentient flag that prohibits 0 hosts or multiple.#825Vizonex wants to merge 2 commits intonodejs:mainfrom
Vizonex wants to merge 2 commits intonodejs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
I'm still trying to brainstorm exactly how to go about this for now this is a draft.
Related to #816 I'm trying to figure out how we can stop a multiple or no host request from being accepted as this is a pretty bad issue that isn't just related to aiohttp aio-libs/aiohttp#10600 but affects other users also.
I do however have a pretty good understanding of llparse's architecture since I made a parody of llparse in python as a pypi package. The only thing that really concerns me is if this will actually reject client requests that do not have a host header or have multiple of them hence this being a draft. I may wind up rewriting this all completely.