Skip to content

test: check contextify contextual store behavior in strict mode#62571

Open
Renegade334 wants to merge 1 commit intonodejs:mainfrom
Renegade334:test-vm-contextual-store
Open

test: check contextify contextual store behavior in strict mode#62571
Renegade334 wants to merge 1 commit intonodejs:mainfrom
Renegade334:test-vm-contextual-store

Conversation

@Renegade334
Copy link
Copy Markdown
Member

Previously, this behaviour was tested indirectly by the REPL tests. However, REPL now uses DONT_CONTEXTIFY for its VM context, so the interceptor behaviour is no longer covered.

Refs: #61898 (comment)
Refs: #62371

Previously, this behavior was tested indirectly by the REPL tests.
However, REPL now uses DONT_CONTEXTIFY for its VM context.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 3, 2026
@Renegade334 Renegade334 requested review from legendecas and targos April 3, 2026 09:37
@Renegade334 Renegade334 added the vm Issues and PRs related to the vm subsystem. label Apr 3, 2026
@targos
Copy link
Copy Markdown
Member

targos commented Apr 3, 2026

Is this going to block the V8 update if it lands before it?

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.72%. Comparing base (b411f90) to head (0913a15).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62571      +/-   ##
==========================================
+ Coverage   89.71%   89.72%   +0.01%     
==========================================
  Files         695      695              
  Lines      214434   214434              
  Branches    41062    41067       +5     
==========================================
+ Hits       192371   192397      +26     
+ Misses      14124    14116       -8     
+ Partials     7939     7921      -18     

see 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@legendecas
Copy link
Copy Markdown
Member

Yes, we should wait until https://crrev.com/c/7718821 been cherry-picked to #61898 before landing this.

Copy link
Copy Markdown
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test LGTM.

@legendecas legendecas added the blocked PRs that are blocked by other issues or PRs. label Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked PRs that are blocked by other issues or PRs. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants